Github user zhichao-li commented on the pull request: https://github.com/apache/spark/pull/7582#issuecomment-124300456 @davies, currently if the first byte is 254 or 255, `numBytesForFirstByte` would return 6 which somehow hide the invalid case not raising exception. What's your opinion? 1)Just stay the same 2)Explicitly raise exception here? or 3)Delete these two entries which would raise outOfRange exception when facing invalid char?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org