Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7635#discussion_r35398027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -135,19 +137,19 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
this
}
- def toBigDecimal: BigDecimal = {
+ def toBigDecimal: BigDecimal = BigDecimal(toJavaBigDecimal)
--- End diff --
If we're in agreement that it should be removed, then I'm glad to update
this patch to do so (which involves adding a MiMa exclusion, I think). We
could also just leave it and decide later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
