Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/7600#discussion_r35399262
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/RateController.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.streaming.scheduler
+
+import java.util.concurrent.atomic.AtomicLong
+
+import scala.concurrent.{ExecutionContext, Future}
+
+import org.apache.spark.streaming.scheduler.rate.RateEstimator
+import org.apache.spark.util.ThreadUtils
+
+/**
+ * A StreamingListener that receives batch completion updates, and
maintains
+ * an estimate of the speed at which this stream should ingest messages,
+ * given an estimate computation from a `RateEstimator`
+ */
+private [streaming] abstract class RateController(val streamUID: Int,
rateEstimator: RateEstimator)
+ extends StreamingListener with Serializable {
+
+ protected def publish(rate: Long): Unit
+
+ // Used to compute & publish the rate update asynchronously
+ @transient
+ implicit private val executionContext =
ExecutionContext.fromExecutorService(
+ ThreadUtils.newDaemonSingleThreadExecutor("stream-rate-update"))
+
+ private val rateLimit: AtomicLong = new AtomicLong(-1L)
+
+ /**
+ * Compute the new rate limit and publish it asynchronously.
+ */
+ private def computeAndPublish(time: Long, elems: Long, workDelay: Long,
waitDelay: Long): Unit =
+ Future[Unit] {
+ val newSpeed = rateEstimator.compute(time, elems, workDelay,
waitDelay)
+ newSpeed foreach { s =>
--- End diff --
We dont generally use postfix notation. use `newSpeed.foraech`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
