Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/7584#discussion_r35437342 --- Diff: R/pkg/R/DataFrame.R --- @@ -1384,7 +1384,7 @@ setMethod("saveAsTable", "org.apache.spark.sql.parquet") } allModes <- c("append", "overwrite", "error", "ignore") - if (!(mode %in% allModes)) { + if (! (mode %in% allModes)) { --- End diff -- Yeah lets leave the `!` out of this patch. We can add an exclusion before these two uses to get lintr to pass with no warnings.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org