Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/7554#issuecomment-125182863
Alright, I made some changes to the design.
The main problem was:
RowMatrix initialization needs rows, numRows, numCols for creating a
RowMatrix. However while converting from other matrices to a RowMatrix, the
java model is used directly.
To prevent this, I have used a `RowMatrixModel`, `RowMatrix` being a
wrapper around it, which allows a non-hackish way of initializing.
A minor drawback is that initializing a RowMatrix will give a RowMatrix
instance, but converting it from a CoordinateMatrix will give an instance of
RowMatrixModel, but we can live with it?
Just in case, you were not notified, this is my Pull Request
https://github.com/dusenberrymw/spark/pull/1 . Could you please review it and
merge?
The reason is that the code cutoff is this weekend and it would be great to
get this in.
Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
