Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r35658884
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -128,6 +149,25 @@ case class ExceptionFailure(
}
/**
+ * A class for recovering from exceptions when deserializing a Throwable
that was
+ * thrown in user task code. If the Throwable cannot be deserialized it
will be null,
+ * but the stacktrace and message will be preserved correctly in
SparkException.
+ */
+private[spark] class ThrowableSerializationWrapper(var exception:
Throwable) extends
--- End diff --
its a good idea to make this `private[spark]` if we can -- but its actually
going to leak as a member of `ExceptionFailure`. (I'm surprised that scalac
doesn't catch this.) In any case, I think you can fix this by changing to the
member of `ExceptionFailure` to `private val exceptionWrapper:
Option[ThrowableSerializationWrapper]`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
