Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7705#discussion_r35786334
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala ---
    @@ -197,8 +238,86 @@ class LocalLDAModel private[clustering] (
       // TODO:
       // override def topicDistributions(documents: RDD[(Long, Vector)]): 
RDD[(Long, Vector)] = ???
     
    +  /**
    +   * Calculate and return per-word likelihood bound, using the `batch` of
    +   * documents as evaluation corpus.
    +   */
    +  // TODO: calcualte logPerplexity over training set online during 
training, reusing gammad instead
    +  // of performing variational inference again in [[bound()]]
    +  def logPerplexity(
    +      batch: RDD[(Long, Vector)],
    +      totalDocs: Long): Double = {
    +    val corpusWords = batch
    +      .flatMap { case (_, termCounts) => termCounts.toArray }
    +      .reduce(_ + _)
    +    val subsampleRatio = totalDocs.toDouble / batch.count()
    +    val batchVariationalBound = bound(
    +      batch,
    --- End diff --
    
    OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to