Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/7494#discussion_r35788337 --- Diff: R/pkg/inst/tests/test_sparkSQL.R --- @@ -417,6 +417,32 @@ test_that("collect() and take() on a DataFrame return the same number of rows an expect_equal(ncol(collect(df)), ncol(take(df, 10))) }) +test_that("collect() support Unicode characters", { + convertToNative <- function(s) { + Encoding(s) <- "UTF-8" + enc2native(s) + } + + lines <- c("{\"name\":\"ìë íì¸ì\"}", + "{\"name\":\"æ¨å¥½\", \"age\":30}", --- End diff -- style nit -- could you align this with the `"` above ?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org