Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126115261 Yeah its tricky to add a test case for this -- We could do it by refactoring the code and testing a smaller function which takes in the array size as an argument etc. but that'll be a much bigger code change. Since this is a more contained change I'd actually recommend just merging the current diff for now.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org