Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/999#discussion_r13518281
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDDLike.scala 
---
    @@ -111,4 +111,10 @@ private[sql] trait SchemaRDDLike {
       @Experimental
       def saveAsTable(tableName: String): Unit =
         sqlContext.executePlan(InsertIntoCreatedTable(None, tableName, 
logicalPlan)).toRdd
    +
    +
    +  /**
    +   * Print the schema of this SchemaRDD.
    +   */
    +  def printSchema = queryExecution.analyzed.printSchema()
    --- End diff --
    
    put the return type explicitly here (is it just Unit)?
    
    We should explicitly define returns types of all public functions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to