Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7753#discussion_r35860163
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -85,6 +85,10 @@ private[spark] class Executor(
env.blockManager.initialize(conf.getAppId)
}
+ private val executorMetrics: ExecutorMetrics = new ExecutorMetrics
+ executorMetrics.setHostname(Utils.localHostName)
+ executorMetrics.setPort(env.blockTransferService.port)
--- End diff --
I don't think this is the "right" port -- eg., its not the port that users
will see in the UI elsewhere for the executor. I think that will be the port
in `env.address.port` (that is what is used in the `onExecutorAdded` event).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
