Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7808#discussion_r35929281
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
    @@ -49,9 +49,28 @@ private[ui] class ExecutorThreadDumpPage(parent: 
ExecutorsTab) extends WebUIPage
         val maybeThreadDump = sc.get.getExecutorThreadDump(executorId)
     
         val content = maybeThreadDump.map { threadDump =>
    -      val dumpRows = threadDump.map { thread =>
    +      val dumpRows = threadDump.sortWith{
    +        case (threadTrace1, threadTrace2) => {
    +          val v1 = if (threadTrace1.threadName.contains("Executor task 
launch")) 1 else 0
    +          val v2 = if (threadTrace2.threadName.contains("Executor task 
launch")) 1 else 0
    +          if (v1 == v2) {
    +            threadTrace1.threadId > threadTrace2.threadId
    +          } else {
    +            v1 > v2
    +          }
    +        }
    +      }.map { thread =>
    +        val threadName = thread.threadName
    +        val styleString = "background:" + {
    +          if (threadName.contains("Executor task launch")) {
    --- End diff --
    
    Can we perform this styling using CSS classes instead of inline CSS?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to