Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7139#discussion_r35937603
  
    --- Diff: core/src/main/scala/org/apache/spark/api/r/RUtils.scala ---
    @@ -62,4 +64,7 @@ private[spark] object RUtils {
           }
         }
       }
    +
    +  /** Check if R is installed before running tests that use R commands. */
    +  def isRInstalled: Boolean = Seq("R", "--version").! == 0
    --- End diff --
    
    One minor thing is that this might not work in Windows setups as I think R 
is shipped as `R.exe` in that case. Any ideas if we actually run tests on 
Windows as a part of our release process? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to