Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/7515#discussion_r35946650
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -818,7 +818,8 @@ class Analyzer(
failAnalysis(s"$expr has multiple Window Specifications
($distinctWindowSpec)." +
s"Please file a bug report with this error message, stack
trace, and the query.")
} else {
- distinctWindowSpec.head
+ val unbounded = SpecifiedWindowFrame(RowFrame,
UnboundedPreceding, UnboundedFollowing)
--- End diff --
I think extracting the grouping by and order by clauses is better, and it
also conveys the message that any Window operator should be capable of
processing multiple frames. The impact of the PR will be a bit larger in that
case; I'll have a look at it tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
