Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7855#issuecomment-126937200
For remainder, my hunch is that it's probably failing for extreme floating
point values (e.g. take the remainder of a giant float by another giant float).
I found a similar failure in #7625, an experimental branch of mine which
contains some code for using reflection to write tests against all Expression
subclasses.
The code in my branch lags a bit behind what I have locally (e.g. it may be
missing some of the interpreted vs. codegen comparison code) so I can see about
pushing the rest of my changes later. The approach in my branch probably
definitely isn't the right one for unit testing; it was more intended to be an
experiment to see whether it would be possible to do this all via reflection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
