Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7860#discussion_r36038348 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -113,7 +151,6 @@ public BoxedUnit apply() { * Allocates new sort data structures. Called when creating the sorter and after each spill. */ private void initializeForWriting() throws IOException { - this.writeMetrics = new ShuffleWriteMetrics(); --- End diff -- this was moved into the ctor, as I wasn't sure we wanted to reset writeMetrics after every spill.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org