Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7774#discussion_r36039711
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScan.scala ---
@@ -34,9 +34,16 @@ private[sql] case class LocalTableScan(
protected override def doExecute(): RDD[InternalRow] = rdd
+ override lazy val accumulators = Map(
+ "numRows" -> sparkContext.internalAccumulator(0L, "number of rows"))
+
override def executeCollect(): Array[Row] = {
val converter = CatalystTypeConverters.createToScalaConverter(schema)
- rows.map(converter(_).asInstanceOf[Row]).toArray
+ val numRows = accumulator[Long]("numRows")
--- End diff --
we need a specialized accumulator in order to avoid object allocation in +=.
@zsxwing can you just quickly hack together a LongAccumulator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
