Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7840#discussion_r36043573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -127,6 +127,8 @@ class CodeGenContext {
dataType match {
case _ if isPrimitiveType(jt) =>
s"$row.set${primitiveTypeName(jt)}($ordinal, $value)"
case t: DecimalType => s"$row.setDecimal($ordinal, $value,
${t.precision})"
+ // The UTF8String may came from UnsafeRow, otherwise clone is cheap
(re-use the bytes)
+ case StringType => s"$row.update($ordinal, $value.clone())"
--- End diff --
Why we need to do copy for `UTF8String` from `UnsafeRow`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
