Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-127051469 @yu-iskw Thanks for adding this, and others for reviewing! It looks good. My only comment is that it might be good to use the built-in MLlib methods like MLUtils.loadVectors to load data, rather than having new parsing methods in examples. Not a big deal though.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org