Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7860#discussion_r36046246
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMapSuite.scala
---
@@ -140,7 +159,21 @@ class UnsafeFixedWidthAggregationMapSuite
map.free()
}
- test("test sorting") {
+ testWithMemoryLeakDetection("test external sorting") {
+ // Calling this make sure we have block manager and everything else
setup.
+ TestSQLContext
+
+ TaskContext.setTaskContext(new TaskContextImpl(
--- End diff --
Should we use a `finally` block to ensure that the TaskContext is cleared
at the end of this test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
