Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7882#discussion_r36114103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -614,8 +614,9 @@ object DateTimeUtils {
*/
def dateAddMonths(days: Int, months: Int): Int = {
val absoluteMonth = (getYear(days) - YearZero) * 12 + getMonth(days) -
1 + months
- val currentMonthInYear = absoluteMonth % 12
- val currentYear = absoluteMonth / 12
+ val nonNegativeMonth = if (absoluteMonth >= 0) absoluteMonth else 0
+ val currentMonthInYear = nonNegativeMonth % 12
+ val currentYear = nonNegativeMonth / 12
--- End diff --
/% is not defined for Int.
I read the notion in a Scala book which I have returned. I will read more
once I have that book back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
