Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7774#issuecomment-127481808 Review status: 7 of 22 files reviewed at latest revision, 68 unresolved discussions, all commit checks successful. --- <sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala, line 81 \[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrl-r4-80)** ([raw file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala#L81)):</sup> Fixed by reimplementing the prepare method --- <sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala, line 83 \[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrl-r4-82)** ([raw file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala#L83)):</sup> Fixed by reimplementing the prepare method --- <sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala, line 132 \[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrj-r4-132)** ([raw file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala#L132)):</sup> Fixed by reimplementing the prepare method --- Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/apache/spark/7774) <!-- Sent from Reviewable.io -->
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org