Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1025#discussion_r13578489
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala 
---
    @@ -156,6 +161,182 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
       }
     
       /**
    +   * Return a subset of this RDD sampled by key (via stratified sampling).
    +   * We guarantee a sample size = math.ceil(fraction * S_i), where S_i is 
the size of the ith
    --- End diff --
    
    Also, it would be good to put a comment saying that this method requires 
two passes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to