Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5717#issuecomment-127713743
We should have a test to guard against reintroduction of the the bug that
@jeanlyn mentioned.
I find the code here to be really dense and hard to understand, so I'd like
to try to pursue my design first. There's another 1.5 blocker / critical
related to eliminating JoinedRow in favor of Tungsten's RowJoiner when
UnsafeRows are used, and I think that the code re-use enabled by my design will
make this significantly easier to accomplish.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
