Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127769997
@dbtsai Earlier, I had recommended "If weightCol is unspecified or an empty
String, then we don't use sample weights." It occurred to me that we should
set the default to an empty String (since Params should have defaults or be
required, in general).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
