Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/7924#discussion_r36265363 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -256,6 +272,15 @@ public boolean hasNext() { @Override public Location next() { int totalLength = PlatformDependent.UNSAFE.getInt(pageBaseObject, offsetInPage); + if (destructive) { + MemoryLocation keyAddress = loc.getKeyAddress(); + Object keyBaseObject = keyAddress.getBaseObject(); + long keyBaseOffset = keyAddress.getBaseOffset(); + + int hashcode = HASHER.hashUnsafeWords(keyBaseObject, keyBaseOffset, loc.getKeyLength()); + int pos = hashcode & map.mask; + this.map.bitset.unset(pos); + } --- End diff -- Above is just used to unset the bitset for each record.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org