Github user lirui-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/892#discussion_r13594625
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -388,7 +386,7 @@ private[spark] class TaskSetManager(
           val curTime = clock.getTime()
     
           var allowedLocality = getAllowedLocalityLevel(curTime)
    -      if (allowedLocality > maxLocality) {
    +      if (allowedLocality > maxLocality && 
myLocalityLevels.contains(maxLocality)) {
    --- End diff --
    
    I'm not sure about this though. It's meant to avoid skipping valid levels 
trying something not as desirable (tasks in pendingTasksWithNoPrefs to be 
specific). Please let me know if you think this should be addressed in another 
JIRA (e.g. with some delay introduced to pendingTasksWithNoPrefs).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to