Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6817#discussion_r36299283
  
    --- Diff: 
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
    @@ -787,6 +791,23 @@ class ExecutorAllocationManagerSuite
           Map("host2" -> 1, "host3" -> 2, "host4" -> 1, "host5" -> 2))
       }
     
    +  test("SPARK-8366: it should be resubmitted later if task fails") {
    --- End diff --
    
    can we come up with a more specific name for this test case?  maybe 
something like "maxNumExecutorsNeeded should properly handle failed & 
resubmitted tasks"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to