Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r36316371 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java --- @@ -252,4 +269,30 @@ public String toString() { .toString(); } } + + /** + * write out the set of registered executors to a file so we can reload them on restart. + * You must have a lock on executors when calling this + */ + private void saveRegisteredExecutors() throws IOException { + if (registeredExecutorFile != null) { + Options options = new Options(); + options.createIfMissing(true); + JniDBFactory factory = new JniDBFactory(); + DB db = null; + try { + db = factory.open(registeredExecutorFile, options); --- End diff -- I guess just paranoia about something going wrong w/ the file in between writes, but probably I should leave that to leveldb to worry about. I just fixed this.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org