Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7924#discussion_r36327671 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -242,7 +247,18 @@ private BytesToBytesMapIterator( } } + public BytesToBytesMapIterator setDestructive(boolean dt, BytesToBytesMap map) { + this.destructive = dt; + this.map = map; + return this; + } + private void advanceToNextPage() { + if (destructive) { + dataPagesIterator.remove(); + this.map.taskMemoryManager.freePage(currentPage); + this.map.shuffleMemoryManager.release(currentPage.size()); + } --- End diff -- Yep, this is exactly where I'd perform the freeing.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org