Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7959#discussion_r36328440
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -210,7 +210,13 @@ private[sql] case class EnsureRequirements(sqlContext:
SQLContext) extends Rule[
def addShuffleIfNecessary(child: SparkPlan): SparkPlan = {
if (!child.outputPartitioning.guarantees(partitioning)) {
- Exchange(partitioning, child)
+ // SPARK-9563: We should remove repartition operators
--- End diff --
This is a case where I'd go with a much more verbose comment explaining
what's happening here so that readers don't need to go to the JIRA to figure
out why this was added (maybe copy and shorten some of my description from the
JIRA).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
