Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7538#discussion_r36361303
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -408,6 +451,119 @@ private[classification] class MultiClassSummarizer
extends Serializable {
}
/**
+ * Abstraction for multinomial Logistic Regression Training results.
+ */
+sealed trait LogisticRegressionTrainingSummary extends Serializable {
+
+ /** objective function (scaled loss + regularization) at each iteration.
*/
+ val objectiveHistory: Array[Double]
+
+ /** Number of training iterations until termination */
+ val totalIterations: Int = objectiveHistory.length
--- End diff --
I think this is OK, but we should test this in a little Java suite.
Implementations within traits can cause Java API problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
