Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8005#discussion_r36483774 --- Diff: core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleExternalSorter.java --- @@ -123,10 +126,10 @@ public UnsafeShuffleExternalSorter( } /** - * Allocates new sort data structures. Called when creating the sorter and after each spill. + * Allocates new sort data structures. Called when creating the inMemSorter and after each spill. */ private void initializeForWriting() throws IOException { - // TODO: move this sizing calculation logic into a static method of sorter: + // TODO: move this sizing calculation logic into a static method of inMemSorter: --- End diff -- sorter
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org