Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7904#discussion_r36486374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/OuterJoin.scala ---
@@ -63,10 +74,12 @@ trait HashOuterJoin {
case LeftOuter => (rightKeys, leftKeys)
case x =>
throw new IllegalArgumentException(
- s"HashOuterJoin should not take $x as the JoinType")
+ s"${getClass.getSimpleName} should not take $x as the JoinType")
}
protected[this] def isUnsafeMode: Boolean = {
+ // TODO(josh): there is an existing bug here: this should also check
whether unsafe mode
+ // is enabled. also, the default for self.codegenEnabled looks
inconsistent to me.
(self.codegenEnabled && joinType != FullOuter
--- End diff --
This will be addressed by @davies' patch to consolidate the Unsafe and
Tungsten configurations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
