Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36557012
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,24 @@ private[spark] class BlockManager(
private def doGetRemote(blockId: BlockId, asBlockResult: Boolean):
Option[Any] = {
require(blockId != null, "BlockId is null")
val locations = Random.shuffle(master.getLocations(blockId))
+ var attemptTimes = 0
for (loc <- locations) {
logDebug(s"Getting remote block $blockId from $loc")
- val data = blockTransferService.fetchBlockSync(
- loc.host, loc.port, loc.executorId,
blockId.toString).nioByteBuffer()
+ val data = try {
+ blockTransferService.fetchBlockSync(
+ loc.host, loc.port, loc.executorId,
blockId.toString).nioByteBuffer()
+ } catch {
+ case t: Throwable if attemptTimes < locations.size - 1 =>
+ // Return null when Exception throw, so we can fetch block
+ // from another location if there still have locations
+ attemptTimes += 1
+ logWarning(s"Try $attemptTimes times getting remote block
$blockId from $loc failed.", t)
+ null
+ case t: Throwable =>
+ // Throw BlockFetchException wraps the last Exception when
+ // there is no block we can fetch
+ throw new BlockFetchException(t)
--- End diff --
can we include a little more info here, eg. `s"failed to fetch block from
${locations.size} locations. Most recent failure cause:"`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
