Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8054#discussion_r36592447
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2013,22 +2009,40 @@ private[spark] object Utils extends Logging {
        */
       def startServiceOnPort[T](
           startPort: Int,
    +      maxPort: Int,
    --- End diff --
    
    I don't see how this addresses the issue, since it just gives a hook into 
this method, but doesn't address how users would specify ranges, or how to deal 
with the new semantics. ALso why would the caller pass in `failedPorts`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to