Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8090#discussion_r36708799
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -787,9 +787,10 @@ class DAGScheduler(
}
}
+ // Create internal accumulators if the stage has no accumulators
initialized.
// Reset internal accumulators only if this stage is not partially
submitted
// Otherwise, we may override existing accumulator values from some
tasks
- if (allPartitions == partitionsToCompute) {
+ if (stage.internalAccumulators.isEmpty || allPartitions ==
partitionsToCompute) {
--- End diff --
@andrewor14 we don't actually care about clearing the values, right? Can
we simplify this to just `if (stage.internalAccumulators.isEmpty)`? Or just
initialize them when a `Stage` is constructed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
