Github user markgrover commented on a diff in the pull request: https://github.com/apache/spark/pull/8093#discussion_r36793126 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -795,7 +796,8 @@ private[spark] object JsonProtocol { case `taskKilled` => TaskKilled case `executorLostFailure` => val executorId = Utils.jsonOption(json \ "Executor ID").map(_.extract[String]) - ExecutorLostFailure(executorId.getOrElse("Unknown")) + val reason = Utils.jsonOption(json \ "Loss Reason").map(_.extract[String]) + ExecutorLostFailure(executorId.getOrElse("Unknown"), reason.getOrElse("Unknown")) --- End diff -- (I'll add a test). About `taskEndReasonFromJson`, this line we are commenting on a part of `taskEndReasonFromJson` but let me know if I am missing something:-) And, I am using Utils.jsonOption() could you please clarify?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org