Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/490#discussion_r13690775
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala 
---
    @@ -138,11 +139,10 @@ class ClientArguments(val args: Array[String], val 
sparkConf: SparkConf) {
       }
     
     
    -  def printUsageAndExit(exitCode: Int, unknownParam: Any = null) {
    -    if (unknownParam != null) {
    -      System.err.println("Unknown/unsupported param " + unknownParam)
    -    }
    -    System.err.println(
    +  def getUsageMessage(unknownParam: Any = null): String = {
    +    val message = if (unknownParam != null) "Unknown/unsupported param " + 
unknownParam+ "\n" else ""
    --- End diff --
    
    `s"Unknown/unsupported param $unknownParam\n"` looks better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to