Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8209#discussion_r37103923
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -211,10 +211,10 @@ public SparkLauncher addSparkArg(String arg) {
        * Adds an argument with a value to the Spark invocation. If the 
argument name corresponds to
        * a known argument, the code validates that the argument actually 
expects a value, and throws
        * an exception otherwise.
    -   * <p/>
    +   * <p>
    --- End diff --
    
    Hm I though that's because it now required valid HTML, like  `<p>...</p>`. 
Well, if it fixes an error, obviously that's better than an error. There seem 
to be ~17 occurrences of this in the code base though -- worth fixing it in one 
go?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to