Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8178#issuecomment-131203131
nice find. We could also use an `IndexedSeq` (which I think is what
everyone really wants anytime they say `Seq`), but it looks like there are
other places that want an array anyway, so makes sense to just use an array
here. `IndexedSeq` would leave the door open for other optimizations -- eg.,
when the storage level is `None`, you don't actually need to create anything,
you can just return a collection which knows its `Nil` in every slot ... but
that would probably be premature optimization.
anyway, just some random thoughts. lgtm pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
