Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1058#discussion_r13726891
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -329,15 +326,16 @@ private[spark] class BlockManager(
* never deletes (recent) items.
*/
def getLocalFromDisk(blockId: BlockId, serializer: Serializer):
Option[Iterator[Any]] = {
- diskStore.getValues(blockId, serializer).orElse(
- sys.error("Block " + blockId + " not found on disk, though it should
be"))
+ diskStore.getValues(blockId, serializer).orElse {
+ throw new SparkException(s"Block $blockId not found on disk, though
it should be")
--- End diff --
Well should this just do nothing if the block is not found (other than
return `None`)? I think we handle this correctly downstream from this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
