Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r37179224
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -501,6 +501,10 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case LessThanOrEqual(l, r) => GreaterThan(l, r)
// not(not(e)) => e
case Not(e) => e
+ // De Morgan's law: !(a || b) => !a && !b
--- End diff --
@chenghao-intel The `Not` case added here is not for simplification. It's
used to push `Not` predicates to the bottom, so that `e` in `Not(e)` cannot be
either `And` or `Or`. CNF conversion code relies on this assumption.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
