Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/8226#issuecomment-132090343
@chenghao-intel Currently we will do an `UnsafeProjection` for two
`UnsafeRow`s. I think it will also create a new `UnsafeRow`?
This patch replaces it with a `GenerateUnsafeRowJoiner` to join two
`UnsafeRow`s. For `InternalRow`s, this patch does as same as the current way
(`JoinedRow`).
This patch also optimises `GenerateUnsafeRowJoiner` with a new `withRight`
method. So we can skip some unnecessary memory copying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
