Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/981#discussion_r13738022
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -25,7 +25,12 @@ import org.apache.spark.storage.RDDInfo
* Stores information about a stage to pass from the scheduler to
SparkListeners.
*/
@DeveloperApi
-class StageInfo(val stageId: Int, val name: String, val numTasks: Int, val
rddInfos: Seq[RDDInfo]) {
+class StageInfo(
+ val stageId: Int,
+ val name: String,
+ val numTasks: Int,
+ val rddInfos: Seq[RDDInfo],
+ val details: String = "") {
--- End diff --
I'd rather make this a required constructor parameter. The case where you
use the optionality here is actually one we need to address. We need to deal
with this new field in `JsonProtocol.scala` where we define a serializer for
`StageInfo`'s (i.e. we should write and read-back the description). There, we
should make sure we handle the case where you are reading an older serialized
`StageInfo` that doesn't have a `details` field. This functionality is required
for Spark's history UI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
