Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8197#discussion_r37336485
  
    --- Diff: docs/ml-linear-methods.md ---
    @@ -118,12 +133,114 @@ lrModel = lr.fit(training)
     print("Weights: " + str(lrModel.weights))
     print("Intercept: " + str(lrModel.intercept))
     {% endhighlight %}
    +</div>
     
     </div>
     
    +The `spark.ml` implementation of logistic regression also supports
    +extracting a summary of the model over the training set. Note that the
    +predictions and metrics which are stored as `Datafram`s in
    +`BinaryLogisticRegressionSummary` are annoted `@transient` and hence
    --- End diff --
    
    Yep, you're right.
    
    IMO the user guide is targeted at helping users use our library as fast as 
possible. Hence, we should not include information that isn't relevant to 
someone who just wants to use the library.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to