Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8267#discussion_r37346725
  
    --- Diff: docs/ml-features.md ---
    @@ -1389,3 +1389,145 @@ print(output.select("features", "clicked").first())
     
     # Feature Selectors
     
    +## VectorSlicer
    +
    +`VectorSlicer` is a transformer that takes a feature vector and outputs a 
new feature vector with a sub-array of the original features. It is useful for 
extracting features from a vector column.
    +
    +`VectorSlicer` accepts a vector column with a specified indices, then 
outputs a new vector column whose values are selected via those indices. There 
are two types of indices, 
    +
    + 1. Integer indices that represents the real indices in the vector, 
`setIndices()`;
    --- End diff --
    
    I would remove the word "real" (i.e. "...that represent the indices into 
the vector") since it could be confused for real numbers (i.e. real-valued 
indices, which don't really make sense)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to