Github user li-zhihui commented on a diff in the pull request:

    https://github.com/apache/spark/pull/900#discussion_r13740596
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -48,6 +48,10 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, actorSystem: A
       var totalCoreCount = new AtomicInteger(0)
       val conf = scheduler.sc.conf
       private val timeout = AkkaUtils.askTimeout(conf)
    +  val minRegisteredNum = conf.getDouble("spark.executor.minRegisteredNum", 
0)
    --- End diff --
    
    @tgravescs 
    I think default value the config property should be 0 for keeping 
consistent with previous version, whatever we use number or percentage. 
    In my opinion, using executor number as config property should keep 
consistent with the args(and conf, env) --num-executors, user  can accept the 
conf property more easily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to