Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/8007#discussion_r37359578
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -207,6 +211,17 @@ private[yarn] class YarnAllocator(
}
/**
+ * Gets the executor loss reason for a disconnected executor.
+ * Note that this method is expected to be called exactly once per
executor ID.
+ */
+ def getExecutorLossReason(executorId: String): ExecutorLossReason =
synchronized {
+ allocateResources()
+ // Expect to be asked for a loss reason once and exactly once.
+ assert(completedExecutorExitReasons.contains(executorId))
--- End diff --
In such a case that AMRM client can't be guaranteed to find the latest
container exit statuses, then we would need to do polling and perhaps "give up"
after a few tries? I don't see how we could ever guarantee that
getExecutorLossReason could ever be correct if we can't ever be guaranteed to
find the correct state from the NM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
