Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8276#issuecomment-132782565 I took a more detailed look at the code and I only had some minor comments inline. So I think it looks pretty good but I think taking this opportunity to add some tests to SerDe is a good idea.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org